Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
12
to
14
|
|
||
| const activeEnv = process.env.GATSBY_ENV || process.env.NODE_ENV || 'development'; | ||
|
|
There was a problem hiding this comment.
Bug: The fetch call in resolveOpenAPI lacks error handling for non-200 responses, which can cause the build process to fail if the remote file is unavailable.
Severity: MEDIUM
Suggested Fix
Check the response.ok property after the fetch call. If the response is not okay, throw a more informative error or handle it gracefully to prevent the build from crashing with an unhandled exception.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/build/resolveOpenAPI.ts#L12-L14
Potential issue: The `fetch` call in `resolveOpenAPI.ts` to retrieve
`openapi-derefed.json` from GitHub does not handle potential HTTP errors. If the fetch
fails due to network issues, an invalid commit SHA, or GitHub returning a non-200 status
code (e.g., 404, 500), the subsequent call to `response.json()` will throw an unhandled
exception. This will cause the entire static site generation process to fail, preventing
deployment. While this is a build-time failure, it introduces fragility into the build
pipeline.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
|
Closing stale PR. The bump-api-schema workflow has been fixed to merge immediately in #16827. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.